Feature: Caller Member on Static Default Logger #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpvreony
changed the title
|
Looks like the API tests are failing at the moment btw. |
|
busy couple of months. need to sort some test coverage as well |
Codecov Report
@@ Coverage Diff @@
## main #569 +/- ##
==========================================
+ Coverage 70.14% 71.78% +1.63%
==========================================
Files 98 99 +1
Lines 4569 4717 +148
==========================================
+ Hits 3205 3386 +181
+ Misses 1364 1331 -33
Continue to review full report at Codecov.
|
|
As part of this pr can you bump the version.json file. Once you've merge this pr we'll get it to do a release |
glennawatson
changed the title
glennawatson
approved these changes
Jan 22, 2021
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Closes #341 adds a static logging interface and default implementation for capturing callermemberdata.
What is the current behavior?
static logger doesn't have context information
What is the new behavior?
What might this PR break?
the interface has new, currently hasn't got any of the param array methods, so if anyone using them on the default logger, it will break their build.
Please check if the PR fulfills these requirements
Other information:
WIP - need to update api approval and tests